fix(e2e): public throwaway repo + tolerate per-cycle 403#50
Merged
Conversation
The e2e run surfaced it: a private repo on a free org 403s on classic branch protection (and rulesets/environments). Create the throwaway repo public so those feature-gated reads are available; still deleted on teardown. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
A cycle whose fetchLive 403s (App lacks that permission, or the feature isn't on the org's plan) is now skipped with a warning rather than failing the suite — while still asserting fetchLive only issued GETs even on the failure path. Keeps the harness robust to the App's permission scope; grant the org read scopes for fuller coverage. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes from the first live e2e runs against a real org (
lex00-e2e):fetchLive403s (App lacks that permission, or feature not on the plan) is skipped with a warning instead of failing the suite, while still assertingfetchLiveonly issued GETs. Keeps the harness robust to the App's permission scope.Result (live run on lex00-e2e)
14/14 passed — provision → exercise all cycles → apply (topic) → teardown, no leftover repos. 11 cycles validated;
teams+ orgrulesetsskipped (App lacks org Members/Administration read — grant for fuller coverage).🤖 Generated with Claude Code